Eliminate use of cursor move counting from OD_HTML_Tag_Processor#1861
Draft
westonruter wants to merge 5 commits intotrunkfrom
Draft
Eliminate use of cursor move counting from OD_HTML_Tag_Processor#1861westonruter wants to merge 5 commits intotrunkfrom
OD_HTML_Tag_Processor#1861westonruter wants to merge 5 commits intotrunkfrom
Conversation
westonruter
added
[Type] Enhancement
westonruter
changed the title
westonruter
changed the title
OD_HTML_Tag_Processor
Restore deprecated method without using it
westonruter
force-pushed
the
remove/cursor-move-counting
branch
from
bc8a3f1 to
6d979f7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #1861 +/- ##
=======================================
Coverage 66.64% 66.64%
=======================================
Files 88 88
Lines 7015 7018 +3
=======================================
+ Hits 4675 4677 +2
- Misses 2340 2341 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
Author
|
Interestingly, the attribute order changes in one of the snapshots with the backport in place: -<video data-od-added-preload data-od-xpath="/HTML/BODY/DIV[@class='wp-site-blocks']/*[1][self::FIGURE]/*[1][self::DIV]/*[1][self::VIDEO]" preload="auto" src="https://example.com/video1.mp4" poster="https://example.com/poster1.jpg" width="640" height="480"></video>\n
+<video data-od-xpath="/HTML/BODY/DIV[@class='wp-site-blocks']/*[1][self::FIGURE]/*[1][self::DIV]/*[1][self::VIDEO]" data-od-added-preload preload="auto" src="https://example.com/video1.mp4" poster="https://example.com/poster1.jpg" width="640" height="480"></video>\nThe test is passing in |
westonruter
modified the milestones:
optimization-detective 1.0.0-beta3,
optimization-detective n.e.x.t
5 tasks
westonruter
modified the milestones:
optimization-detective 1.0.0-beta4,
optimization-detective 1.0.0-beta5
westonruter
modified the milestones:
optimization-detective 1.0.0-beta5,
optimization-detective 1.0.0-beta6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deprecates the use of
\OD_HTML_Tag_Processor::get_cursor_move_count()in favor of backporting an adaptation of the internal fix put in place for WP 6.8 in Core-62085.This will facilitate eventually allowing the use of
WP_HTML_Tag_Processorinstead ofWP_HTML_Tag_Processor, which will handles all of HTML's unique parsing conditions.